RLock server when checking shard groups #2475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otoolep
force-pushed
the
fix_race_during_shards_group_check
branch
from
07ac198
to
846a857
Compare
This fixes a race detected by the race detector. "Create shard groups" commands must be broadcast across the cluster without holding the server lock so the commands are created under lock, and then processed after releasing the lock.
otoolep
force-pushed
the
fix_race_during_shards_group_check
branch
from
846a857
to
b93554e
Compare
|
Green build, ready to merge. |
|
👍 |
otoolep
added a commit
that referenced
this pull request
May 1, 2015
…heck RLock server when checking shard groups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a race detected by the race detector. "Create shard groups"
commands must be broadcast across the cluster without holding the server
lock so the commands are created under lock, and then processed after
releasing the lock.