Fix client response check after PR #2298 #2558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The write endpoint is returning StatusNoContent instead of StatusOK when the write is successful.
|
@vladlopes good catch. however, you'll need to fix the associated tests before we can merge this. let me know if you're interested in doing that, otherwise one of us can take it over. |
|
I will take care of the tests... |
The Client return a nil (json null) response on a sucessful write
|
nice... i couldn't figure out why |
|
awesome, kicked the build and we're green. 👍 |
|
Maybe we should also check for a nil response on the client test (https://github.com/influxdb/influxdb/blob/master/client/influxdb_test.go#L116)? The test is discarding it... |
toddboom
added a commit
that referenced
this pull request
May 13, 2015
Fix client response check after PR #2298
|
@vladlopes would you mind signing the CLA? Thanks! |
|
@toddboom Just did! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The write endpoint is returning
StatusNoContentinstead ofStatusOKwhen the write is successful.This will be important only for clients that check for returning
*Responsebeing nil, as in both cases theerrreturned will be nil.