Convert OpenTSDB to service #2823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if p.Time < 10000000000 { | ||
| ts = time.Unix(p.Time, 0) | ||
| } else { | ||
| ts = time.Unix(p.Time/1000, (p.Time%1000)*1000) |
There was a problem hiding this comment.
I'm assuming we are converting to ms here? But a comment to clarify would be helpful.
|
+1 on green build. |
|
I also reviewed this code, particularly to see if it had implications for #2799. The WaitGroup handling here seems OK, so +1 from me. |
|
Obviously +1 on a green build, as per @corylanou |
benbjohnson
force-pushed
the
opentsdb
branch
4 times, most recently
from
37006dc
to
2e3d5f2
Compare
|
I don't where the PointsWriter is supplied to this service, by the production code. |
| if err := h.PointsWriter.WritePoints(&cluster.WritePointsRequest{ | ||
| Database: h.Database, | ||
| RetentionPolicy: h.RetentionPolicy, | ||
| ConsistencyLevel: cluster.ConsistencyLevelOne, |
There was a problem hiding this comment.
This looks hardcoded. Does this mean clients will have no control over consistency level with openTSDB?
There was a problem hiding this comment.
I just want to convert the old server over to a service right now. We can add consistency level separately.
This commit converts the OpenTSDB endpoint into a service.
|
OK, let's get it in. Thanks for the final changes. |
benbjohnson
added a commit
that referenced
this pull request
Jun 8, 2015
Convert OpenTSDB to service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request converts the OpenTSDB server into a service and adds some tests.