Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix excessive shard group creation logging #3030

Merged
merged 2 commits into from
Jun 17, 2015
Merged

Fix excessive shard group creation logging #3030

merged 2 commits into from
Jun 17, 2015

Conversation

otoolep
Copy link
Contributor

@otoolep otoolep commented Jun 17, 2015

Fixes issue #3029.

With this change in place, logging only occurs when shards are actually created.

@otoolep
Copy link
Contributor Author

otoolep commented Jun 17, 2015

Before this fix, there was regular spewing of log messages that gave the impression shard groups were being created.

2015/06/17 13:07:04 pre-creating successive shard group for group 4, database db, policy rp
2015/06/17 13:07:04 new shard group 1 successfully created
2015/06/17 13:17:04 pre-creating successive shard group for group 1, database db, policy rp
2015/06/17 13:17:04 new shard group 3 successfully created
2015/06/17 13:17:04 pre-creating successive shard group for group 2, database db, policy rp
2015/06/17 13:17:04 new shard group 4 successfully created
2015/06/17 13:17:04 pre-creating successive shard group for group 3, database db, policy rp
2015/06/17 13:17:04 new shard group 5 successfully created
2015/06/17 13:17:04 pre-creating successive shard group for group 4, database db, policy rp
2015/06/17 13:17:04 new shard group 1 successfully created
2015/06/17 13:27:04 pre-creating successive shard group for group 1, database db, policy rp
2015/06/17 13:27:04 new shard group 3 successfully created
2015/06/17 13:27:04 pre-creating successive shard group for group 2, database db, policy rp
2015/06/17 13:27:04 new shard group 4 successfully created

@otoolep
Copy link
Contributor Author

otoolep commented Jun 17, 2015

@corylanou @benbjohnson

@otoolep otoolep added this to the 0.9.1 milestone Jun 17, 2015
@otoolep otoolep self-assigned this Jun 17, 2015
@corylanou
Copy link
Contributor

+1 silence is golden!

otoolep added a commit that referenced this pull request Jun 17, 2015
@otoolep
Merge pull request #3030 from influxdb/better_sg_logging
c9906d8 
Fix excessive shard group creation logging
@otoolep otoolep merged commit c9906d8 into master Jun 17, 2015
@otoolep otoolep deleted the better_sg_logging branch June 17, 2015 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@otoolep otoolep

Labels
None yet
Projects
None yet
Milestone
0.9.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@otoolep @corylanou