Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a number of issues in sysV init script. #3136

Merged
merged 3 commits into from
Jun 25, 2015

Conversation

miguelcnf
Copy link
Contributor

When using the sysV init script the service actions return codes were not being properly set.

What this means is that the init script would return successfully even when, for instance, it failed to load the configuration and the process wasn't left running.

As the influx process doesn't fork itself we're waiting for the pid file to be created and checking the status of the process afterwards.

@otoolep
Copy link
Contributor

otoolep commented Jun 25, 2015

Thanks @miguelcnf -- we'll take a look. Have you signed the CLA?

@miguelcnf miguelcnf changed the title Fix sysV init script return codes. Fix a number of issues in sysV init script. Jun 25, 2015
@miguelcnf
Copy link
Contributor Author

Hi @otoolep, I have now! :)

Also, just pushed a couple more fixes, mainly the ability to run as a non-root user.

@otoolep
Copy link
Contributor

otoolep commented Jun 25, 2015

I tested this, and it looks good. +1

@otoolep
Copy link
Contributor

otoolep commented Jun 25, 2015

Failure to launch looks good:

root@script-test:~# service influxdb start
Starting the process influxd [ OK ]
influxd process failed to start [ FAILED ]
root@script-test:~# echo $?
1

@jwilder
Copy link
Contributor

jwilder commented Jun 25, 2015

LGTM 👍

otoolep added a commit that referenced this pull request Jun 25, 2015
Fix a number of issues in sysV init script.
@otoolep otoolep merged commit e9a0628 into influxdata:master Jun 25, 2015
@otoolep
Copy link
Contributor

otoolep commented Jun 25, 2015

Thanks @miguelcnf

@miguelcnf
Copy link
Contributor Author

Thanks!

@miguelcnf miguelcnf deleted the init_script_fixes branch June 26, 2015 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants