Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated wal & flush parameters in default config #3298

Merged
merged 1 commit into from
Jul 11, 2015
Merged

Updated wal & flush parameters in default config #3298

merged 1 commit into from
Jul 11, 2015

Conversation

jhorwit2
Copy link
Contributor

As you can see here, it appears the configuration parameters were updated in code, but not the default configuration.

As you can see [here](https://github.com/influxdb/influxdb/blob/b2b69c63fe9105c1a9ba72f5b2517e1bb896b8bb/tsdb/config.go#L23), it appears the configuration parameters were updated in code, but not the default configuration.
@otoolep
Copy link
Contributor

otoolep commented Jul 11, 2015

Thanks @jhorwit2 for this very important fix to the sample config. Have you signed the CLA?

https://influxdb.com/community/cla.html

@jhorwit2
Copy link
Contributor Author

Just did :)

@otoolep
Copy link
Contributor

otoolep commented Jul 11, 2015

Great, thanks.

Merging, sample config change only.

otoolep added a commit that referenced this pull request Jul 11, 2015
Updated wal & flush parameters in default config
@otoolep otoolep merged commit 12a2480 into influxdata:master Jul 11, 2015
@mcastilho
Copy link
Contributor

@otoolep @jhorwit2 This was merged, but it is incorrect.... the new toml annotation field names are incorrect.

The right is

wal-flush-interval
wal-partition-flush-delay

a not with the max_ prefix

@jhorwit2
Copy link
Contributor Author

Very good catch. i'll submit a pr now

@jhorwit2
Copy link
Contributor Author

#3340

@otoolep
Copy link
Contributor

otoolep commented Jul 15, 2015

Wow -- thanks @mcastilho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants