Allow semicolons to trail database names in "use" #3356
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
First time contributor here! I read the contribution guidelines, but it wasn't apparent if you folks wanted me to update the CHANGELOG or if that was something that you all handled. Also, the guidelines said to drop in the checkboxes, but I'm not sure if I should check off the relevant ones (I've signed the CLA). |
|
@timraymond thanks for the PR! Please do update the CHANGELOG, I'll ask a core member to review the PR |
|
@dgnorton can you validate this parser PR? |
Prior to this commit, the "use" command treated trailing semicolons as significant parts of the database name. This lead to a confusing user experience since other parts of influxql treat the trailing semicolon as a statement separator, or appear to ignore it. A typical use case looks something like: > show databases; -- snip -- > use foo; This commit trims off trailing semicolons from database names in "use" commands if present to match user expectations. Fixes influxdata#2258
timraymond
force-pushed
the
use-with-semicolon
branch
from
6cf6258
to
bdfec0e
Compare
|
+1 from me and @toddboom. Confirmed CLA has been signed. |
|
Rebased here: #3364 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the "use" command treated trailing semicolons as
significant parts of the database name. This lead to a confusing user
experience since other parts of influxql treat the trailing semicolon as
a statement separator, or appear to ignore it. A typical use case looks
something like:
This commit trims off trailing semicolons from database names in "use"
commands if present to match user expectations.
Fixes #2258, where this appears to have been an underlying issue.