Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3403 - Added check for escaped single quote in string #3404

Merged
merged 1 commit into from
Jul 22, 2015

Conversation

jhorwit2
Copy link
Contributor

#3403

> create database test;
> use test
Using database test
> insert test value="foo'bar"
> select * from test
name: test
----------
time                value
2015-07-21T00:15:43.034952116Z  foo'bar

> select * from test where value = 'foo'bar'
ERR: error parsing query: found bar, expected SELECT, DELETE, SHOW, CREATE, DROP, GRANT, REVOKE, ALTER, SET at line 1, char 39
> select * from test where value = 'foo''bar'
ERR: error parsing query: found bar, expected SELECT, DELETE, SHOW, CREATE, DROP, GRANT, REVOKE, ALTER, SET at line 1, char 38
> select * from test where value = 'foo\'bar'
name: test
----------
time                value
2015-07-21T00:15:43.034952116Z  foo'bar

> select * from test where value = 'foo'bar'
ERR: error parsing query: found bar, expected SELECT, DELETE, SHOW, CREATE, DROP, GRANT, REVOKE, ALTER, SET at line 1, char 39
> 

@otoolep
Copy link
Contributor

otoolep commented Jul 21, 2015

@dgnorton @benbjohnson

@otoolep
Copy link
Contributor

otoolep commented Jul 21, 2015

+1, seems sensible to me.

Thanks @jhorwit2

@otoolep
Copy link
Contributor

otoolep commented Jul 21, 2015

Can you also update the 0.9.3 CHANGELOG and give yourself credit?

@jhorwit2
Copy link
Contributor Author

Yup. I'll do that now.

@jhorwit2 jhorwit2 force-pushed the jah/parser-fix branch 4 times, most recently from 1c48236 to d169fc5 Compare July 21, 2015 00:45
@jhorwit2
Copy link
Contributor Author

This should be under bug fix right?

@otoolep
Copy link
Contributor

otoolep commented Jul 21, 2015

Yeah, bug fix makes sense to me.

@jhorwit2 jhorwit2 force-pushed the jah/parser-fix branch 2 times, most recently from d9a4df7 to e597e2e Compare July 21, 2015 22:24
@jhorwit2
Copy link
Contributor Author

@otoolep anyone idea when this will be merged? Keeping conflicts with changelog file up to date is tedious haha.

@dgnorton
Copy link
Contributor

+1 Thanks @jhorwit2!

dgnorton added a commit that referenced this pull request Jul 22, 2015
Fixes #3403 - Added check for escaped single quote in string
@dgnorton dgnorton merged commit 2c9497f into influxdata:master Jul 22, 2015
@jhorwit2 jhorwit2 deleted the jah/parser-fix branch July 22, 2015 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants