Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build branch to version information #3635

Merged
merged 2 commits into from
Aug 13, 2015
Merged

Conversation

otoolep
Copy link
Contributor

@otoolep otoolep commented Aug 12, 2015

Enhance the information displayed by the version command, to minimize any confusion about built code.

@otoolep
Copy link
Contributor Author

otoolep commented Aug 12, 2015

Example output:

$ ./influxd version
InfluxDB v1.0 (git: master 1234)

@otoolep
Copy link
Contributor Author

otoolep commented Aug 12, 2015

@toddboom

@otoolep otoolep modified the milestones: 0.9.4, 0.9.3 Aug 12, 2015
@otoolep otoolep self-assigned this Aug 12, 2015
@corylanou
Copy link
Contributor

I wonder if we should add that to the http headers as well, or maybe that's getting to noisy. Currently we send down the version header with each request, but not the build:

https://github.com/influxdb/influxdb/blob/master/services/httpd/handler.go#L674

Thoughts?

@otoolep
Copy link
Contributor Author

otoolep commented Aug 12, 2015

@corylanou -- I think that would be too noisy. I think just the version is the right thing to do for HTTP headers, but I don't feel that strongly about it.

@corylanou
Copy link
Contributor

I don't feel that strongly either. If they really need it, it will be in the log from when they start.

@beckettsean
Copy link
Contributor

@otoolep @corylanou I could see adding the full information into the HTTP headers when hitting the /ping endpoint, otherwise it seems unnecessary. If it's not trivial to do it only for the ping endpoint then I say leave it out for now.

@otoolep
Copy link
Contributor Author

otoolep commented Aug 13, 2015

@corylanou -- does this get a +1 from you?

@corylanou
Copy link
Contributor

+1

otoolep added a commit that referenced this pull request Aug 13, 2015
Add build branch to version information
@otoolep otoolep merged commit c81a0af into master Aug 13, 2015
@otoolep otoolep deleted the add_branch_to_version branch August 18, 2015 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants