-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build branch to version information #3635
Conversation
Example output:
|
I wonder if we should add that to the http headers as well, or maybe that's getting to noisy. Currently we send down the version header with each request, but not the build: https://github.com/influxdb/influxdb/blob/master/services/httpd/handler.go#L674 Thoughts? |
@corylanou -- I think that would be too noisy. I think just the version is the right thing to do for HTTP headers, but I don't feel that strongly about it. |
I don't feel that strongly either. If they really need it, it will be in the log from when they start. |
@otoolep @corylanou I could see adding the full information into the HTTP headers when hitting the /ping endpoint, otherwise it seems unnecessary. If it's not trivial to do it only for the ping endpoint then I say leave it out for now. |
ee0e7f0
to
d1e102a
Compare
@corylanou -- does this get a +1 from you? |
+1 |
Add build branch to version information
Enhance the information displayed by the
version
command, to minimize any confusion about built code.