Fix two panics in the WAL #3884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If LoadMetadataIndex() tries to log an error, it causes a panic because the logger is not set until Open() is called, which is after LoadMetaDataIndex() returns. Instead, just set the logger up when the WAL is created.
addToCache is called in a goroutine and can panic if the server is closed while opening. If part of the open func errors, it returns an error and immediately calls close. close sets p.cache to nil which causes the goroutine trying to initialized the cache to panic as well. The goroutine should run under a write lock to avoid this race/panic.
| @@ -500,6 +500,9 @@ func (l *Log) openPartitionFiles() error { | |||
| for _, p := range l.partitions { | |||
|
|
|||
| go func(p *Partition) { | |||
| p.mu.Lock() | |||
There was a problem hiding this comment.
Why does this address the issue?
There was a problem hiding this comment.
See the commit message for f5f8f04
|
Sounds reasonable, thanks @jwilder |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are panics that occur when the server is starting but hits errors. You can recreate them by truncating the metadata index file a few bytes. I managed to get a truncated file locally from a bad shutdown.