Rollback bolt tx on mapper open error #4034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes `SelectMapper.Open()` so that it properly rolls back transactions. Previously, this caused transactions to stay open indefinitely which caused mmap resizes to hang indefinitely.
| if lm.queryTMin == 0 || lm.intervalSize == 0 { | ||
| lm.numIntervals = 1 | ||
| lm.intervalSize = lm.queryTMax - lm.queryTMin | ||
| if err := func() error { |
There was a problem hiding this comment.
This line and the conditional block at the bottom are the only changes in this PR.
|
+1 |
2 similar comments
|
👍 |
|
+1 |
benbjohnson
added a commit
that referenced
this pull request
Sep 8, 2015
Rollback bolt tx on mapper open error
|
Great fix. On Tuesday, September 8, 2015, Ben Johnson notifications@github.com wrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This commit fixes
SelectMapper.Open()so that it properly rolls back transactions. Previously, this caused transactions to stay open indefinitely which caused mmap resizes to hang indefinitely.