Prohibit dropping the default retention policy #4053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to prevents users from putting their system into an awkward state. It is a policy that all databases must have at least a default retention policy. Fixes issue #3699.
| @@ -172,6 +172,11 @@ func (data *Data) DropRetentionPolicy(database, name string) error { | |||
| return ErrDatabaseNotFound | |||
| } | |||
|
|
|||
| // Prohibit dropping the default retention policy. | |||
| if di.DefaultRetentionPolicy == name { | |||
There was a problem hiding this comment.
would this ever be case sensitive?
There was a problem hiding this comment.
Retention policy names are already case sensitive, so this just continues with this policy. If we ever change that, we'll need to change a lot more code.
|
One question, otherwise +1 |
|
+1 |
otoolep
added a commit
that referenced
this pull request
Sep 9, 2015
Prohibit dropping the default retention policy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to prevents users from putting their system into an awkward
state. It is a policy that all databases must have at least a default
retention policy.
Fixes issue #3699.