influxql: when using derivative, check 'group by time' instead of 'where time ...' #4149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @peekeri -- you can see the test failures here: Please be sure to run 'go test ./...' after you've made your changes, so you can see which tests need updating. |
|
@otoolep, yep I noticed the tests are failing. I didn't change them as they are failing because of the changed logic in ast.go and I wanted to see if that seems like a reasonable thing to do. I'll fix the tests anyway. |
peekeri
force-pushed
the
derivative_fix
branch
from
cbc3918
to
e9685d2
Compare
…ere time ...' When using derivative, it is required that aggregate function is used as sub-call when grouping by time is used. However, AST parsing used to check if WHERE-clause contained condition with 'time'. Fix this by changing check to see if groupByInterval is present. Modify also related error case tests and add check for select derivative(...) ... where time > ...
peekeri
force-pushed
the
derivative_fix
branch
from
e9685d2
to
c844ec1
Compare
|
Fixed the failing tests and added one for accepting time condition in WHERE-clause. |
jwilder
added a commit
that referenced
this pull request
Sep 30, 2015
influxql: when using derivative, check 'group by time' instead of 'where time ...'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix for #4148.
When using derivative, it is required that aggregate function is used as
sub-call when grouping by time is used. However, AST parsing used to check
if WHERE-clause contained condition with 'time'.
Fix this by changing check to see if groupByInterval is present.