Implement bottom #4161
Merged
Implement bottom #4161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the rework of the ordering for top, this was just a matter of adding a flag telling the minheap which way the values should be sorted.
| @@ -1407,7 +1422,7 @@ func ReduceTop(values []interface{}, c *influxql.Call) interface{} { | |||
| if whichselected == -1 { | |||
| // none of the points have any values | |||
| // so we can return what we have now | |||
| sort.Sort(topReduceOut{out}) | |||
| sort.Sort(topReduceOut{out, c.Name == "bottom"}) | |||
There was a problem hiding this comment.
should topReduceOut -> topBottomReduceOut?
There was a problem hiding this comment.
Missed that one.
|
One minor question, otherwise +1. Looks fantastic! |
Also, gofmt
|
+1, but this does need a CHANGELOG entry under features. |
added 2 commits
September 21, 2015 12:06
resolve changelog conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the rework of the ordering for top, this was just a matter
of adding a flag telling the minheap which way the values should
be sorted.