Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple UDP + JSON input plugins #591

Closed
wants to merge 1 commit into from
Closed

Add support for multiple UDP + JSON input plugins #591

wants to merge 1 commit into from

Conversation

tpitale
Copy link
Contributor

@tpitale tpitale commented May 29, 2014

Support comes by way of [[input_plugins.udp_servers]] in config.
A single port will map to a single database.

  • Update sample config to include [[input_plugins.udp_servers]] example
  • Change configuration.Configuration to hold config for array of udp servers
  • Change configuration.UdpInputPortString to accept a port int
  • Modify udp.NewServer to accept listenAddress string, database string
  • Modify server.Server struct to hold an array of udp.Server
  • Modify server.NewServer to not create any udp.Server
  • Update server.ListenAndServe to check and instantiate all instances of udp.Server

@tpitale
Copy link
Contributor Author

tpitale commented May 29, 2014

I tried to run the build and tests locally. It said there was an error … but the only one it showed was that there was already a port bound on 8083. Maybe tests conflict with a run influxdb instance?

Support comes by way of [[input_plugins.udp_servers]] in config.
A single port will map to a single database.

* Update sample config to include [[input_plugins.udp_servers]] example
* Change configuration.Configuration to hold config for array of udp servers
* Change configuration.UdpInputPortString to accept a port int
* Modify udp.NewServer to accept listenAddress string, database string
* Modify server.Server struct to hold an array of udp.Server
* Modify server.NewServer to not create any udp.Server
* Update server.ListenAndServe to check and instantiate all instances of udp.Server
@tpitale
Copy link
Contributor Author

tpitale commented May 29, 2014

I would perhaps like to add integration tests for this. If that's required, I will investigate and this can be a WIP.

@tpitale
Copy link
Contributor Author

tpitale commented May 29, 2014

All tests pass locally. Had to shut down my local influxdb.

@tpitale
Copy link
Contributor Author

tpitale commented May 29, 2014

Oh, question: is there a way to mark the old configuration pattern as deprecated if this udp_servers config is the way udp should be configured going forward?

@jvshahid jvshahid added this to the 0.7.1 milestone May 29, 2014
@jvshahid jvshahid closed this in 90e9af0 May 29, 2014
@jvshahid
Copy link
Contributor

Thanks @tpitale for contributing to InfluxDB. You may want to take a look at this commit (since this is your first go contribution) where I slightly modified the code to make it more idiomatic 9a6cc74.

@jvshahid
Copy link
Contributor

@tpitale do you mind signing the CLA really quick. You can find it on our website http://influxdb.com/community/cla.html

@tpitale
Copy link
Contributor Author

tpitale commented May 29, 2014

Signing now. BRB.

@tpitale
Copy link
Contributor Author

tpitale commented May 29, 2014

Done.

@jvshahid
Copy link
Contributor

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants