Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Super classes for model classes #32

Open
KKuehlem opened this issue Sep 14, 2023 · 3 comments
Open

Super classes for model classes #32

KKuehlem opened this issue Sep 14, 2023 · 3 comments

Comments

@KKuehlem
Copy link

It would be great for better programming to have proper super classes for the model classes. For example, all WhatsApp model classes have fields like "from", "to", "messageId", "callbackData" and notfiyUrl (Inlcuding getters).
This also applies to the SendWhatsApp<...>Request classes and the object they return with the executeMethod.

For example, I want to have a method which sends the request to do some processing which is not dependent on the type of request, but using the current classes I have to do a lot of method overriding, duplicating code and e.g. using lamdas to send the requests instead of handling an abstract request.

@ib-plivaja
Copy link

Dear @KKuehlem ,

I apologize for the delay in my response. I appreciate your patience.

Could you kindly provide the code snippet related to processing the classes in question? Additionally, please specify the version of the infobip-api-java-client library that we should review.

Thank you for using our library, and I look forward to assisting you further.

Best regards,
Petra

@KKuehlem
Copy link
Author

Thanks, but I already solved the problem for me. The version was 4.0.0, it is hard to share a snippet for this, because is is more of a broader problem / suggestion

@ib-plivaja
Copy link

Hi @KKuehlem,

this issue in the library is not in our focus at the moment. We will see in the future what we could do to achieve this.

Best,
Petra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants