Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraform Provider Development Program - Second Review #66

Closed
6 of 7 tasks
cgriggs01 opened this issue Feb 25, 2020 · 13 comments
Closed
6 of 7 tasks

Terraform Provider Development Program - Second Review #66

cgriggs01 opened this issue Feb 25, 2020 · 13 comments

Comments

@cgriggs01
Copy link
Contributor

cgriggs01 commented Feb 25, 2020

Hey Team, I took another review pass at this repository and here is my current feedback:

  • I have haven’t attempted to create an Infoblox support account, but I’m not sure my submission has gone through. Could you provide an organization_id so that I can get access to the Infoblox binary.

  • The provider must have documentation built for the provider its resources and data sources as well and guide that can help users that will be posted to terraform.io. All for the official Terraform providers follow the same format for the website docs.

    • Once you add the new makefile, you should be able to run make website to deploy your website docs locally.
  • The GNUmakefile should align with the standard makefile, you should copy of the Github GNUmakefileand you’l just need to change line Wapi Validate Function and Gateway ip address #4 PKG_NAME=infoblox

  • All official Terraform provider use a Mozilla Public License 2.0 within each repo, can you change from the Apache license to a MPL2.0 LICENSE file in this repository.

  • The CHANGELOG formatting will have to be updated to conform to the standard provider format since the changeling is updated by a bot during the release it must be in a certain format. With the AWS provider changelog as an example, the version of the next release should be tagged as “1.0.0 (Unreleased)” and will then be updated with a date by the release-bot.

  • One of our Terraform Ecosystem engineers built a linter to help align coding best practices for providers. You should use it along with your development moving forward. https://github.com/bflad/tfproviderlint. There is only one test failing right now with is AT003 but that should not be a require and you can disregard it.

  • Each Terraform provider requires a .travis.yml which is use to just run the unit test to verify that the provider builds successfully as a PR check in the repo.

@saiprasannasastry
Copy link
Contributor

#47
was the review done from this branch? this has documentation , Updated Make file as well, all that is pending is a trvais.yaml. Can you confirm if you have done a review on the given PR

@saiprasannasastry
Copy link
Contributor

for the first one , get in touch with our PM

@mocofound
Copy link

mocofound commented Dec 17, 2020

Will infobloxopen/terraform-provider-infoblox be published to the Terraform Registry?

Providers can be published here: https://registry.terraform.io/publish/provider

Update (July 2021): The verified Infoblox Terraform provider is now available in the Terraform Registry:

https://registry.terraform.io/providers/infobloxopen/infoblox/latest

@AvRajath
Copy link
Contributor

@mocofound yep will be doing that

@mzazon
Copy link

mzazon commented Jan 16, 2021

Curious if there have been any updates regarding the provider review? Keen to use this soon!

@barryib
Copy link

barryib commented Feb 9, 2021

I'm probably make some noise, but is there any ETA for publishing this provider in the registry ?

@barryib
Copy link

barryib commented Feb 23, 2021

@cgriggs01 how can we help on this ?

@somashekhar
Copy link
Contributor

"Presently we are working on couple of enhancements. Once we are done with them we would be looking to publish it under verified provider. We will be soon reaching out."

@aweberlopes
Copy link

Can we support you on this? It would be nice if we could get in the near future a published version on the terraform registry.

@cgriggs01
Copy link
Contributor Author

With the new provider Registry the publishing process is self service and con be done once the a release has been built using Github actions.

This issue and feedback was from our old process of onboarding providers into the native ecosystem.

@tvories
Copy link

tvories commented Apr 6, 2021

This was closed, but I don't see this provider in the official registry. Have you published this yet?

@somashekhar
Copy link
Contributor

Not yet. We have a similar issue at https://github.com/infobloxopen/terraform-provider-infoblox/issues/67. You can track it for updates.

@mocofound
Copy link

The verified Infoblox Terraform provider is now available in the Terraform Registry:

https://registry.terraform.io/providers/infobloxopen/infoblox/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants