Skip to content

Commit

Permalink
Cleaning up overzealous Elastic IP inclusion (alternative fix to #222)
Browse files Browse the repository at this point in the history
  • Loading branch information
temujin9 committed Dec 11, 2012
1 parent 91b2616 commit 8341a4c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/ironfan/provider/ec2/elastic_ip.rb
Expand Up @@ -50,7 +50,7 @@ def self.load!(cluster=nil)
#

def self.save!(computer)
return unless computer.created?
return unless (computer.created? and not computer.server.ec2.elastic_ip.nil?)
elastic_ip = computer.server.ec2.elastic_ip
Ironfan.step(computer.name, "associating Elastic IP #{elastic_ip}", :blue)
Ironfan.unless_dry_run do
Expand Down

1 comment on commit 8341a4c

@UncleTallest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very similar to and, in my opinion, a better placement of the code to what I suggested on Nick's original comment. Good call.

Please sign in to comment.