Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extra role="main" from the templates #1033

Closed
Sovia opened this issue Apr 20, 2021 · 0 comments · Fixed by #1034
Closed

Remove extra role="main" from the templates #1033

Sovia opened this issue Apr 20, 2021 · 0 comments · Fixed by #1034
Assignees
@Sovia
Labels
priority: high team: landmark [1] Velocity rating (Fibonacci)
Projects
Enterprise 4.51.x (Apr 2021) Sprint

Comments

@Sovia
Copy link
Contributor

Sovia commented Apr 20, 2021

Describe the bug
Remove excess role="main" from templates and HostBindings, as there should only be one at the start of main content for the page.

example; https://github.com/infor-design/enterprise-ng/blob/main/projects/ids-enterprise-ng/src/lib/stepprocess/soho-stepprocess.component.ts#L166

Expected behavior
All excess role="main" are removed

Version

  • ids-enterprise-ng: 4.9.4

Platform

  • All

Additional context
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/Main_role#accessibility_concerns
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques#landmark_roles
@Sovia Sovia self-assigned this Apr 20, 2021
@tmcconechy tmcconechy added [1] Velocity rating (Fibonacci) priority: high team: landmark labels Apr 20, 2021
@tmcconechy tmcconechy added this to To do in Enterprise 4.51.x (Apr 2021) Sprint via automation Apr 20, 2021
@Sovia Sovia mentioned this issue Apr 21, 2021
Merged
@tmcconechy tmcconechy moved this from To do to Ready for QA (beta) in Enterprise 4.51.x (Apr 2021) Sprint Apr 22, 2021
@tmcconechy tmcconechy moved this from Ready for QA (beta) to Done in Enterprise 4.51.x (Apr 2021) Sprint Apr 22, 2021
@tmcconechy tmcconechy moved this from Done to NG Checked and Done in Enterprise 4.51.x (Apr 2021) Sprint Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sovia Sovia

Labels
priority: high team: landmark [1] Velocity rating (Fibonacci)
Projects
No open projects
Enterprise 4.51.x (Apr 2021) Sprint
  
NG Checked and Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1033 remove role main from step process infor-design/enterprise-ng
2 participants
@tmcconechy @Sovia