-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAP: Add buttonsetAPI to dialog #1101
Comments
I dont know how tricky this is going to be as the buttonsetAPI is for the modal and the CAP has a toolbar. So maybe its something else. Will have to look |
@tmcconechy, alright, didn't know that. Basically, I think we just need a way (API) to enable/disable the buttons, users should not be able to press save when a form is invalid etc. Preventing the dialog from closing we can do in the newly added/exposed beforeClose (previously lacking from CAP) I assume. |
That doesn't seem too bad maybe we can just map this to one thing (buttonSetAPI) |
Its possible without angular (or maybe this is a usable way as well) if you make the toolbar use all HTML like this example https://github.com/infor-design/enterprise/blob/main/app/views/components/contextualactionpanel/test-complex-toolbar.html#L14 and dont use the button setting https://main-enterprise.demo.design.infor.com/components/contextualactionpanel/test-complex-toolbar.html (use flex toolbar instead tho). There is no way to do it in angular with the button settings. I would make a new feature request and we could add the ability to set the button type to |
This issue is now resolved. |
Is your feature request related to a problem? Please describe.
Missing buttonsetAPI for CAP dialog (should have it just like standard dialog).
Describe the solution you'd like
I want the buttonsetAPI to be available for CAP dialog, i.e. added to the enterprise project (don't think it is), and typings added to this enterprise-ng project.
Additional context
This issue/feature request was mentioned in #1048 but was not addressed. We need this for new UI of M3 where we heavily rely on the CAP dialog, and need to be able to disable dialog buttons when forms are not valid etc.
We will need these types in Angular as well
The text was updated successfully, but these errors were encountered: