Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory Leak: Card, ListView, Toolbar-Flex, HeaderToolbar an #1275

Closed
GMInf opened this issue Apr 20, 2022 · 1 comment · Fixed by #1278
Closed

Memory Leak: Card, ListView, Toolbar-Flex, HeaderToolbar an #1275

GMInf opened this issue Apr 20, 2022 · 1 comment · Fixed by #1278

Comments

@GMInf
Copy link
Contributor

GMInf commented Apr 20, 2022

Describe the bug
Memory leak on IDS components. Detached Html Elements accumulates after destroying these components:
Card, ListView, Toolbar-Flex, HeaderToolbar and Datagrid-Custom Formatter Components

Card – http://localhost:4200/ids-enterprise-ng-demo/cards
Toolbar Flex - http://localhost:4200/ids-enterprise-ng-demo/toolbar-flex-basic
ListView - http://localhost:4200/ids-enterprise-ng-demo/listview
Header-Toolbar - http://localhost:4200/ids-enterprise-ng-demo/header-toolbar
Datagrid Custom Formatter - http://localhost:4200/ids-enterprise-ng-demo/datagrid-custom-formatter

To Reproduce
Steps to reproduce the behavior:

  1. Run enterprise-ng
  2. Select the Card demo
  3. Open Dev tools
  4. Select Memory tab – select Allocation Instrumentation on timeline
  5. Record and stop after 3 seconds. This is to stablish a baseline for comparing the detached html elements
  6. Filter for “detached html”
  7. Start a new record
  8. Click on the demo next to Card demo and then go back to Card demo. This should destroy the components on Card demo and create new ones
  9. Click on Force Garbage Collect and Stop recording
  10. Filter for “detached html”
  11. Compare the two recordings
  12. New detached elements have been added. This accumulates as more Card demo components are created and destroyed.

Expected behavior
There should be no detached HTML elements found after destroying the components. Other demo components does not leave any or accumulate any detached HTML elements.

Version

  • ids-enterprise-ng: [main/13.x]

Screenshots
Attached video of the replication

Platform

  • OS Version: [e.g. Windows 11
Meeting.now-20220420_135714-Meeting.Recording.mp4
  • Browser Name [e.g. chrome]
  • Browser Version [100.0.4896.75 (Official Build) (64-bit)]

Additional context

Meeting.now-20220420_133638-Meeting.Recording.mp4

Add any other context about the problem here.
Opening and closing components on the enterprise-ng demo components to check for memory leaks.

@CindyMercadoReyes
Copy link

This issue is now resolved.

@CindyMercadoReyes CindyMercadoReyes moved this from Ready for QA (beta) to Done in Enterprise 4.63.x (Apr 2022) Sprint May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high team: m3 Issues for m3 type: bug 🐛 [5] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

7 participants