Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IdsDataGrid: Change Sort to use Excel Like Sort #1158

Closed
tmcconechy opened this issue Feb 28, 2023 · 2 comments · Fixed by #1177
Closed

IdsDataGrid: Change Sort to use Excel Like Sort #1158

tmcconechy opened this issue Feb 28, 2023 · 2 comments · Fixed by #1177
Assignees
Labels
type: bug 🐛 Something isn't working [3] Velocity rating (Fibonacci)

Comments

@tmcconechy
Copy link
Member

tmcconechy commented Feb 28, 2023

Describe the bug

The logic has been changed in EP for sort to match what excel does. On an initial quick attempt i couldn't make it work in this project.

Sort function is noted on https://github.com/infor-design/enterprise/pull/7263/files

To Reproduce

Steps to reproduce the behavior:

  1. Go to new example https://github.com/infor-design/enterprise-wc/pull/1159/files
  2. Click on product name
  3. Sort should match https://main-enterprise.demo.design.infor.com/components/datagrid/test-combo-sort.html

Expected behavior
This is how Excel sorts this kind of data:

  • numeric values are grouped together (sorted numerically)
  • text values are grouped next (sorted alphabetically)
  • blank values are at the bottom of the list (both ascending and descending)
  • For example, Excel will sort like this:

Ascending: 1, 2, 07, 11, 1a, 22a, 2ab, a, B, c
Descending: c, B, a, 2ab, 22a, 1a, 11, 07, 2, 1

Add docs for this as well and tests

Additional context
Can either use this solution or another infor-design/enterprise#6787 (comment) depending what works

@hey-yall
Copy link
Collaborator

Also tracked in Jira for designers: https://jira.infor.com/browse/IDS-962

@janahintal
Copy link
Contributor

QA Passed. Now working as expected in https://main-enterprise.demo.design.infor.com/components/datagrid/test-combo-sort.html thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Something isn't working [3] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants