Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card Footer is positioned outside its Card #1240

Closed
mrtipsytony opened this issue Apr 19, 2023 · 1 comment · Fixed by #1421
Closed

Card Footer is positioned outside its Card #1240

mrtipsytony opened this issue Apr 19, 2023 · 1 comment · Fixed by #1421
Assignees
Labels
type: bug 🐛 Something isn't working [2] Velocity rating (Fibonacci)

Comments

@mrtipsytony
Copy link

mrtipsytony commented Apr 19, 2023

Describe the bug
When trying to add <div slot="card-footer"> inside the ids-card, the footer is positioned outside. Currently trying this first in the wc-examples repo.

To Reproduce

Steps to reproduce the behavior:

  1. Fork and clone the examples repository
  2. In react-ts-ids-wc directory, run npm install
  3. Open react-ts-ids-wc/src/examples/ids-card/index.tsx and add a card footer and also update the content body in one of the cards. See image of the changes here:
    image
  4. Save the file and run npm run start to launch the IDS Web Components site in localhost:3000
  5. Once it launches, in the side bar, click and expand Layouts and click Card option.
  6. See the footer inside the card view is out of place
    image

Here's a fork repo of my changes: https://github.com/mrtipsytony/enterprise-wc-examples

Expected behavior
The box should be inside the card view.

Additional Dev Notes:
It looks like we have a position:absolute in the styles for .ids-card-footer. Turning that off seems to fix the issue.

Version

  • ids-enterprise: 1.0.0.beta-8

Screenshots
If applicable, add screenshots to help explain your problem.

Platform

  • Infor Application/Team Name: [e.g. Infor XYZ, Infor ABC]
  • Device: (if applicable) [e.g. iPhone 6 or Samsung Galaxy S6]
  • OS Version: [e.g. Windows 10 or iOS 8]
  • Browser Name: Microsoft Edge
  • Browser Version: [e.g. 22, 66.0.3359.181 (Official Build) (64-bit)]

Additional context
Add any other context about the problem here.

@tmcconechy tmcconechy added type: bug 🐛 Something isn't working [2] Velocity rating (Fibonacci) labels Apr 19, 2023
@tmcconechy
Copy link
Member

@mrtipsytony im doing some work on cards and widgets and wondering where the footer should be. Is this for a homepage portal like layout or just a single arbitrary card on a page.

I.E. where does the card with a footer appear in your use case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Something isn't working [2] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants