Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IdsDataGrid: Select across pages / contextual toolbar? #1565

Closed
volante007 opened this issue Oct 23, 2023 · 8 comments · Fixed by #1739
Closed

IdsDataGrid: Select across pages / contextual toolbar? #1565

volante007 opened this issue Oct 23, 2023 · 8 comments · Fixed by #1739
Assignees
Labels
design Needs input from IDS Design Team type: enhancement ✨ New feature or request [3] Velocity rating (Fibonacci)

Comments

@volante007
Copy link

volante007 commented Oct 23, 2023

Describe the Issue
Doesn't seem to be a way to allow selecting across pages? I can't find any setting for that, and it doesn't work out of the box (using server side paging). Also, is there any alternative to the contextual toolbar available in 4.x?

Select across pages 4.x
https://design.infor.com/code/ids-enterprise/latest/demo/components/datagrid/example-paging.html

  1. Select one row
  2. Go to other page
  3. Go back to first page
    Result: Selection kept
    Web component: Selection not kept (or, it seems it's actually selected, but selection column shows unchecked)

Contextual toolbar 4.x
https://design.infor.com/code/ids-enterprise/latest/demo/components/datagrid/example-multiselect.html

  1. Select one or more rows
    Result: A contextual toolbar appears which contains actions for the selected row(s)

Is there any plan to support these two features, or is there any alternative?

I guess we can achieve/keep the contextual toolbar simply by toggling it ourselves based on the selection, and make it animate as in 4.x.

So, the selection issue is more important out of the two.

@tmcconechy tmcconechy added type: enhancement ✨ New feature or request [3] Velocity rating (Fibonacci) labels Oct 30, 2023
@tmcconechy
Copy link
Member

@volante007 some features we did not add to reduce the amount we support.

  1. select across pages -> could probably add, will discuss
  2. contextual action toolbar -> was discussed and design doesnt like it, decided to should work with toolbar buttons hiding and showing as per IdsDataGrid: Add Contextual Toolbar / Selection Actions #1029 (comment) ->. ut we may want an example for this.

@volante007
Copy link
Author

Hi @tmcconechy , toolbar with actions enabled/disabled based on selections sounds OK to me.

As for select across pages, I found it mentioned in the datagrid TODO (one of the last listed as major):
https://github.com/infor-design/enterprise-wc/blob/main/src/components/ids-data-grid/TODO.md

And as I mentioned, it seems to be selected in the API, but not showing as selected in the selection column. So probably a bug rather than feature missing.

Bottom line: I'm hoping it will be fixed as it's listed as a TODO already :)

@tmcconechy
Copy link
Member

Agreed, i would also argue we need it as its useful on the lookup.

@hey-yall
Copy link
Collaborator

Design resources requested via Jira ticket https://jira.infor.com/browse/IDS-1812

@jbrcna
Copy link
Contributor

jbrcna commented Jan 10, 2024

QA Failed.
verified in https://main.wc.design.infor.com/ids-data-grid/pagination-client-side.html
when using delete/clear button, it only clears/deletes the selected item on a selected page. Also, the text on the top/left of the Datagrid toolbar does not reflect the correct number of records upon deleting/clearing an item.
Large GIF (1708x398)

https://main.wc.design.infor.com/ids-data-grid/tree-grid-virtual-scroll.html
child was not selected.
image

@tmcconechy
Copy link
Member

@EdwardCoyle want a new issue for that or want to look?

@tmcconechy
Copy link
Member

@jbrcna lets make a new issue for this point we will have to follow up on it later

@jbrcna
Copy link
Contributor

jbrcna commented Jan 12, 2024

new issues have been created #1757 , #1758

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Needs input from IDS Design Team type: enhancement ✨ New feature or request [3] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

7 participants