Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IdsDataGrid: Column header filter button is also aligning to the right #1575

Closed
eaenriquez opened this issue Oct 25, 2023 · 6 comments · Fixed by #1633
Closed

IdsDataGrid: Column header filter button is also aligning to the right #1575

eaenriquez opened this issue Oct 25, 2023 · 6 comments · Fixed by #1633
Assignees
Labels
team: m3 type: enhancement ✨ New feature or request [2] Velocity rating (Fibonacci)

Comments

@eaenriquez
Copy link

Describe the Issue
Having a Datagrid column that is right aligned is also aligning the filter button to the right.

To Reproduce
Steps to see the question or problem:

  1. Render a datagrid column and data with one column set to right align

What are you trying to do
To not also align the button to the right inside the datagrid column's header

What did you try so far
N/A

Version

  • ids-enterprise-wc: 1.0.0-beta.15

Screenshots
image

Platform

  • Browser Name: Chrome
  • Browser Version: 118.0.5993.70 (Official Build) (64-bit)
@tmcconechy
Copy link
Member

@eaenriquez why would it make sense to change to not right align the button?

@tmcconechy tmcconechy changed the title Datagrid-WC: Column header filter button is also aligning to the right IdsDataGrid: Column header filter button is also aligning to the right Oct 30, 2023
@tmcconechy tmcconechy added type: enhancement ✨ New feature or request [2] Velocity rating (Fibonacci) labels Oct 30, 2023
@EdwardCoyle EdwardCoyle self-assigned this Oct 31, 2023
@tmcconechy
Copy link
Member

tmcconechy commented Oct 31, 2023

Since we have align: 'right' and headerAlign: 'right' already. I propose we add filterAlign so you can do this..
Screenshot 2023-10-31 at 12 38 16 PM

   align: 'right',
    headerAlign: 'right', // optional because its the same
    filterAlign: 'left' <-- new
  });

@eaenriquez
Copy link
Author

@eaenriquez why would it make sense to change to not right align the button?

It is just we never had this from the soho-components and this is preferred by the stakeholders of our project.

@tmcconechy
Copy link
Member

Ok no worries @eaenriquez we decided it looks ok and we can add a new option here.

@glenlieorillo
Copy link
Contributor

Fix has been applied. However, if you change to RTL (other locale) it doesn't change its position like the other filters.

image

image

@tmcconechy
Copy link
Member

@EdwardCoyle good point ☝🏻 I forget to test RTL here. Do you want a new issue or just do a supplemental fix here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team: m3 type: enhancement ✨ New feature or request [2] Velocity rating (Fibonacci)
Projects
No open projects
4 participants