Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add flags to control verbosity of output #278

Open
shonfeder opened this issue Oct 14, 2020 · 11 comments
Open

[FEATURE] Add flags to control verbosity of output #278

shonfeder opened this issue Oct 14, 2020 · 11 comments
Assignees
Labels
DevOps As practice, not role. Subsumes CI/CD, project organization, operationalization etc. product-owner-triage This should be triaged by the product owner testing usability UX improvements

Comments

@shonfeder
Copy link
Contributor

When a user isn't concerned with the timestamps that indicate how long steps take to run, this part of the output can add noisy and non-deterministic output that doesn't add value. It could be useful to add a way to silence this when desired.

This would be useful, for instance, in cleaning up our integration tests.

See #270 (comment) for context.

@shonfeder shonfeder added the new New issue to be triaged. label Oct 14, 2020
@shonfeder shonfeder self-assigned this Oct 14, 2020
@konnov konnov added this to the v0.14.0-infrastructure milestone Oct 26, 2020
@konnov konnov added the Finfra-backlog Feature: Infrastructure improvements backlog label Dec 6, 2020
@konnov konnov modified the milestones: v0.14.0-infrastructure, backlog2021 Dec 11, 2020
@konnov
Copy link
Contributor

konnov commented Dec 3, 2021

The unix tools are usually able to detect whether they output to the terminal. In that case, I would leave the time stamp and remove them, when the output is different from tty. However, I have no idea about how to detect that in JVM.

@shonfeder
Copy link
Contributor Author

shonfeder commented Dec 3, 2021

Looks like this could help? https://stackoverflow.com/questions/1403772/how-can-i-check-if-a-java-programs-input-output-streams-are-connected-to-a-term

I still doubt whether the time stamps on stdout on every line are useful at all, or indeed, whether most of the output is really useful (especially with the detailed.log readily available) ;)

@konnov
Copy link
Contributor

konnov commented Dec 3, 2021

Colored output on the terminal would be awesome :-)

@konnov
Copy link
Contributor

konnov commented Dec 3, 2021

We can always add the quiet flag -q. That should be easy.

@shonfeder
Copy link
Contributor Author

At #1279 (review) Igor suggested adjusting whether the timestamps are printed based on whether we're using a TTY.

@konnov
Copy link
Contributor

konnov commented Feb 22, 2022

I am also getting annoyed by the timestamps from time to time. How about the following rather stupid solution: Remove the timestamps and write a wrapper script for apalache-mc that adds timestamps to every line of stdout? This can be probably done inside the shell script too.

@konnov
Copy link
Contributor

konnov commented Feb 22, 2022

Obviously, someone has thought about this too: https://serverfault.com/questions/310098/how-to-add-a-timestamp-to-bash-script-log

@shonfeder
Copy link
Contributor Author

Why not just make this configurable in the Scala logging? Why would we move it into a wrapper script?

@konnov
Copy link
Contributor

konnov commented Feb 22, 2022

oh, actually you are right! I am overcomplicating things 🤦

@shonfeder
Copy link
Contributor Author

I'll take this ticket! Seems we are more motivated to get it done now, and I think it should be fairly straightforward.

@shonfeder
Copy link
Contributor Author

Oh, and I'm already assigned, lol :)

@shonfeder shonfeder added testing DevOps As practice, not role. Subsumes CI/CD, project organization, operationalization etc. and removed new New issue to be triaged. Finfra-backlog Feature: Infrastructure improvements backlog labels Mar 23, 2022
@konnov konnov added product-owner-triage This should be triaged by the product owner usability UX improvements labels Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DevOps As practice, not role. Subsumes CI/CD, project organization, operationalization etc. product-owner-triage This should be triaged by the product owner testing usability UX improvements
Projects
None yet
Development

No branches or pull requests

2 participants