Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial updates #147

Closed
wants to merge 5 commits into from
Closed

Tutorial updates #147

wants to merge 5 commits into from

Conversation

ivan-gavran
Copy link
Collaborator

@ivan-gavran ivan-gavran commented Sep 9, 2022

  • included simulation in the tutorial
  • used a more meaningful predicate to illustrate sampling

Merge together with: Modelator#280

Remaining issues:

Blocking:

  • Next release of modelator
  • Bump modelator version

@rnbguy
Copy link
Member

rnbguy commented Sep 9, 2022

but wait till we discuss about this.

@ivan-gavran
Copy link
Collaborator Author

ivan-gavran commented Sep 30, 2022

I tried this out, but the same problem persists:

root:reactor.py:22 Step: Transfer
INFO     root:reactor.py:36 	Sender:    Alice (cosmos1skjykwsfedmr9x4e3m87qcmlqm93tuypxhudwu)
INFO     root:reactor.py:37 	Receiver:  Bob (cosmos1jsfzp2rre5lug0q76k7raryvc85nfql6pcua5e)
INFO     root:reactor.py:38 	Amount:    100stake
INFO     root:reactor.py:43 Status: Error
INFO     root:reactor.py:44 	code: 5
INFO     root:reactor.py:45 	log:  failed to execute message; message index: 0: 80stake is smaller than 100stake: insufficient funds

I am curious about why it mentions 80stake: this does not seem to any constants that we've seen in config files.

@ivan-gavran
Copy link
Collaborator Author

I am curious about why it mentions 80stake: this does not seem to any constants that we've seen in config files.

The 80stake comes from the fact that in the reactor we are sending 20stake for gas.
However, if I try to remove it, I get

out of gas in location: ReadFlat; gasWanted: 0, gasUsed: 1000: out of gas

Thus, the question is: is there a way to remove any fees (including fees for gas). Or, if it does not make sense, then should we always include gas cost into our models?

@rnbguy
Copy link
Member

rnbguy commented Oct 4, 2022

From my previous reply 🙂

But the question remains if we want to model gas fees in our specs.

@ivan-gavran
Copy link
Collaborator Author

From my previous reply 🙂

But the question remains if we want to model gas fees in our specs.

No, I tried that (in my previous reply :) ) and the same problem persists (so, there must be something else)

@ivan-gavran ivan-gavran self-assigned this Oct 17, 2022
@ivan-gavran ivan-gavran linked an issue Oct 17, 2022 that may be closed by this pull request
@ivan-gavran ivan-gavran marked this pull request as ready for review October 17, 2022 14:29
@ivan-gavran ivan-gavran added the user support Improvements or additions to documentation or learning materials label Oct 17, 2022
Copy link
Member

@rnbguy rnbguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Great that you removed the mdx blocks from tutorials.

I added a commit to test out modelator changes in CI. Should be updated with new modelator release before merge.

@rnbguy
Copy link
Member

rnbguy commented Nov 2, 2022

@ivan-gavran, the MDX tests are failing. Can you please look into it?

@ivan-gavran ivan-gavran closed this Nov 9, 2022
@ivan-gavran ivan-gavran deleted the ivan/update_transfer branch November 22, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user support Improvements or additions to documentation or learning materials
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No fees by default
2 participants