Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli): use jinja over copier #181

Merged
merged 7 commits into from Nov 18, 2022
Merged

refactor(cli): use jinja over copier #181

merged 7 commits into from Nov 18, 2022

Conversation

rnbguy
Copy link
Member

@rnbguy rnbguy commented Nov 9, 2022

Closes #166

  • removes git and copier dependency
  • includes templates in atomkraft package
  • atomkraft init works offline now
  • atomkraft init uses correct templates on PR workflows

Otherwise, atomkraft init stays virtually the same.

Since this removes git dependency, init doesn't initialize a git repo anymore.

  • added cli test

@rnbguy rnbguy self-assigned this Nov 9, 2022
@rnbguy rnbguy changed the title refactor: use jinja over copier refactor(cli): use jinja over copier Nov 9, 2022
@rnbguy rnbguy force-pushed the rano/template branch 2 times, most recently from eaebaf1 to 099ab56 Compare November 9, 2022 18:49
@rnbguy rnbguy added the enhancement New feature or request label Nov 10, 2022
@rnbguy rnbguy force-pushed the rano/template branch 5 times, most recently from d32f08b to 6171efb Compare November 18, 2022 14:24
@rnbguy
Copy link
Member Author

rnbguy commented Nov 18, 2022

CI will be successful with the newer Modelator version.

Copy link
Collaborator

@ivan-gavran ivan-gavran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve. I only have one doubt: is having .gitkeep files a feature or a bug for the users? On the one hand, if a github repo is not initialized, does it make sense to add those "junk" files? On the other hand, it is likely they will initialize a repo themselves.

@rnbguy
Copy link
Member Author

rnbguy commented Nov 18, 2022

.gitkeep is a hack to include empty directories into git repo 😅

we probably have to rethink how we initialize a project directory. Maybe we keep a map of empty directories and create them on the fly.

@rnbguy rnbguy merged commit 087e3bc into dev Nov 18, 2022
@rnbguy rnbguy deleted the rano/template branch November 18, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify atomkraft init ... subcommand
2 participants