New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(cli): use jinja
over copier
#181
Conversation
jinja
over copier
jinja
over copier
eaebaf1
to
099ab56
Compare
d32f08b
to
6171efb
Compare
CI will be successful with the newer Modelator version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve. I only have one doubt: is having .gitkeep
files a feature or a bug for the users? On the one hand, if a github repo is not initialized, does it make sense to add those "junk" files? On the other hand, it is likely they will initialize a repo themselves.
we probably have to rethink how we initialize a project directory. Maybe we keep a map of empty directories and create them on the fly. |
6171efb
to
c634f71
Compare
c634f71
to
0a9fc25
Compare
0a9fc25
to
b41eb9c
Compare
Closes #166
git
andcopier
dependencyatomkraft
packageatomkraft init
works offline nowatomkraft init
uses correct templates on PR workflowsOtherwise,atomkraft init
stays virtually the same.Since this removes git dependency,
init
doesn't initialize a git repo anymore.