Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spawn event monitor only when needed #1063

Closed
5 tasks done
romac opened this issue Jun 8, 2021 · 0 comments · Fixed by #1575
Closed
5 tasks done

Spawn event monitor only when needed #1063

romac opened this issue Jun 8, 2021 · 0 comments · Fixed by #1575
Assignees
@romac
Labels
A: low-priority Admin: low priority / non urgent issue, expect longer wait time for PR reviews O: new-feature Objective: cause to add a new feature or support
Projects
Hermes Relayer
Milestone
v0.10.0

Comments

@romac
Copy link
Member

romac commented Jun 8, 2021 •
edited
Loading

Crate

ibc-relayer

Summary

Spawn the event monitor only for commands which need it.

Problem Definition

Commands which do not need the event monitor shouldn't need to incur the penalty of spawning it and subscribing to queries.

Proposal

Spawn the event monitor only for commands which need it.

Acceptance Criteria

When commands which do not need the event monitor do not spawn it.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@romac romac added the O: new-feature Objective: cause to add a new feature or support label Jun 8, 2021
@romac romac added this to the 06.2021 milestone Jun 8, 2021
@romac romac self-assigned this Jun 8, 2021
@romac romac added this to To Do in Hermes Relayer via automation Jun 8, 2021
@adizere adizere modified the milestones: 06.2021, 07.2021 Jun 22, 2021
@adizere adizere modified the milestones: 07.2021, 10.2021 Aug 3, 2021
@adizere adizere modified the milestones: 10.2021, 01.2022 Sep 30, 2021
@romac romac added the A: low-priority Admin: low priority / non urgent issue, expect longer wait time for PR reviews label Nov 17, 2021
@romac romac mentioned this issue Nov 17, 2021
Merged
5 tasks
@adizere adizere modified the milestones: v0.10.0, v0.9.1 Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romac romac

Labels
A: low-priority Admin: low priority / non urgent issue, expect longer wait time for PR reviews O: new-feature Objective: cause to add a new feature or support
Projects
No open projects
Hermes Relayer
To Do
Milestone
v0.10.0
2 participants
@romac @adizere