Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive Debug, PartialEq and Eq for module errors #1281

Closed
5 tasks
hu55a1n1 opened this issue Aug 12, 2021 · 0 comments · Fixed by #1282
Closed
5 tasks

Derive Debug, PartialEq and Eq for module errors #1281

hu55a1n1 opened this issue Aug 12, 2021 · 0 comments · Fixed by #1282

Comments

@hu55a1n1
Copy link
Member

Crate

ibc

Summary

Deriving Debug, PartialEq and Eq for module errors will allow library users to match against these errors and react in specific ways.

Proposal

Ideally, all public lib errors should derive Debug, PartialEq and Eq ->

define_error! {
    #[derive(Debug, PartialEq, Eq)]
    Error {
    // ...

Acceptance Criteria

Library users must be able to pattern match against specific errors.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant