Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change fallback compat version of CometBFT from v0.37 to v0.34 #3666

Closed
5 tasks
ljoss17 opened this issue Oct 19, 2023 · 0 comments · Fixed by #3663
Closed
5 tasks

Change fallback compat version of CometBFT from v0.37 to v0.34 #3666

ljoss17 opened this issue Oct 19, 2023 · 0 comments · Fixed by #3663

Comments

@ljoss17
Copy link
Contributor

ljoss17 commented Oct 19, 2023

Summary

Hermes v1.6 uses CometBFT v0.37 as fallback compatibility mode if the chain /status does not have a valid version.

Some chains require the compatibility mode v0.34, such as Celestia. As a temporary fix, the fallback version should be updated to v0.34 until this issue is completed #3623

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ljoss17 ljoss17 mentioned this issue Oct 19, 2023
Merged
7 tasks
@romac romac changed the title Fallback compatibility version of CometBFT from v0.37 to v0.34 Change fallback compat version of CometBFT from v0.37 to v0.34 Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Hermes
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set CompatMode fallback to v0.34 when the version query fails informalsystems/hermes
1 participant
@ljoss17