Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Derive Serialize and Deserialize for structs in ibc_proto::ibc::core and ibc_proto::ibc::applications #2005

Merged
merged 14 commits into from
Mar 24, 2022
Merged

Derive Serialize and Deserialize for structs in ibc_proto::ibc::core and ibc_proto::ibc::applications #2005

merged 14 commits into from
Mar 24, 2022

Conversation

romac
Copy link
Member

@romac romac commented Mar 23, 2022 •
edited
Loading

Closes: cosmos/ibc-proto-rs#3

Description

  • Derive Serialize and Deserialize for structs in ibc_proto::ibc::core and ibc_proto::ibc::applications.
  • Use Google's Protobuf well-known types definitions instead of prost_types so that we can add custom attributes to them.

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@romac romac mentioned this pull request Mar 23, 2022
Closed
6 tasks
@romac romac force-pushed the romac/1988-ibc-proto-serde branch 2 times, most recently from 419d394 to c5a99de Compare March 23, 2022 16:25
adizere
adizere approved these changes Mar 23, 2022
View reviewed changes
Copy link
Member

@adizere adizere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@romac romac force-pushed the romac/1988-ibc-proto-serde branch from c5a99de to e75edca Compare March 24, 2022 09:30
@romac romac merged commit 96dc5c0 into master Mar 24, 2022
@romac romac deleted the romac/1988-ibc-proto-serde branch March 24, 2022 11:06
This was referenced Mar 29, 2022
Closed
Merged
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
@romac @Wizdave97
Derive Serialize and Deserialize for structs in `ibc_proto::ibc::…
e6381af 
…core` and `ibc_proto::ibc::applications` (informalsystems#2005)

Additionally, use Google's Protobuf well-known types definitions instead of `prost_types` so that we can add custom attributes to them.

Co-authored-by: David Salami <wizdave97@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adizere adizere adizere approved these changes

@ancazamfir ancazamfir Awaiting requested review from ancazamfir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@romac @adizere @Wizdave97