Skip to content
This repository has been archived by the owner on Jun 24, 2024. It is now read-only.

infallible impl Payable conversion from byte arrays #157

Closed
rnbguy opened this issue May 7, 2024 · 0 comments · Fixed by #154
Closed

infallible impl Payable conversion from byte arrays #157

rnbguy opened this issue May 7, 2024 · 0 comments · Fixed by #154

Comments

@rnbguy
Copy link
Member

rnbguy commented May 7, 2024

The latest changes in sovereign-sdk-wip makes Spec::Address conversion from arbitrary-sized byte array fallible.

We were using this to create escrow addresses corresponding to all ics20 channels in ibc-transfer module.

To keep this escrow address creation infallible across all Spec implementations, we need to create something else - that implements Payable<Spec>.

A suggestion from sovereign-sdk team is to use ModuleId - which offers infallible conversion from arbitrary-sized byte array and also implements Payable<Spec>.

ref: Sovereign-Labs/sovereign-sdk-wip#547

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant