Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hex string highlights invalid non-hex characters #26

Closed
wesinator opened this issue Jun 9, 2019 · 1 comment · Fixed by #42
Closed

Hex string highlights invalid non-hex characters #26

wesinator opened this issue Jun 9, 2019 · 1 comment · Fixed by #42
Assignees
Labels

Comments

@wesinator
Copy link
Contributor

Current basic hex string regex highlights any characters between = { }

image

Expected: only highlight valid hex string chars a-fA-F0-9?
This will help with identifying invalid strings in rules

@infosec-intern
Copy link
Owner

@wesinator ... and 2 years later I believe this has been fixed. I'll be adding this to release 1.6.0 after I attempt to apply the same logic to address issue #28. In the meantime, if you get around to it can you take a look at the screenshot in the linked PR and let me know if that is or is not what you're looking for, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants