Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced functions naming in tests #7

Closed
sinabakh opened this issue Sep 6, 2020 · 2 comments
Closed

Enhanced functions naming in tests #7

sinabakh opened this issue Sep 6, 2020 · 2 comments

Comments

@sinabakh
Copy link
Contributor

sinabakh commented Sep 6, 2020

In tests, the function that returns the resource config is named like testResourceConfig. But it's not actually testing anything, so it may be better to be named like getTestResourceConfig.
So testAwsNatGatewayConfig would change to getTestAwsNatGatewayConfig.

@aliscott
Copy link
Member

aliscott commented Sep 9, 2020

The Terraform Provider docs and examples seem to use the testAwsNatGatewayConfig naming - see testAccExampleResource here: https://www.terraform.io/docs/extend/testing/acceptance-tests/testcase.html. But I equally see how this could be confusing. I don't have a strong opinion so feel free to update them.

@sinabakh
Copy link
Contributor Author

sinabakh commented Sep 9, 2020

That's interesting, so now I think compatibility with the terraform source code might have its own advantages. So we can let them be as they are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants