Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): logged out error for most commands #1130

Merged
merged 4 commits into from Mar 4, 2022
Merged

fix(cli): logged out error for most commands #1130

merged 4 commits into from Mar 4, 2022

Conversation

kimskimchi
Copy link
Contributor

Summary

Checklist

  • Wrote appropriate unit tests - see CLI: setup tests #1129
  • Considered security implications of the change
  • Updated associated docs where necessary
  • Updated associated configuration where necessary
  • Change is backwards compatible if it needs to be (user can upgrade without manual steps?)
  • Nothing sensitive logged
  • Commit message conforms to Conventional Commit

Related Issues

Resolves #1128

@kimskimchi
Copy link
Contributor Author

Just adds a mustBeLoggedIn for most commands

mxyng
mxyng reviewed Mar 3, 2022
View reviewed changes
internal/cmd/cmd.go Outdated Show resolved Hide resolved
mxyng
mxyng reviewed Mar 3, 2022
View reviewed changes
internal/cmd/cmd.go Outdated Show resolved Hide resolved
BruceMacD
BruceMacD approved these changes Mar 3, 2022
View reviewed changes
Copy link
Collaborator

@BruceMacD BruceMacD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good once conflicts are resolved.

mxyng
mxyng reviewed Mar 3, 2022
View reviewed changes
internal/cmd/cmd.go Outdated Show resolved Hide resolved
mxyng
mxyng reviewed Mar 3, 2022
View reviewed changes
internal/cmd/cmd.go Outdated Show resolved Hide resolved
mxyng
mxyng approved these changes Mar 3, 2022
View reviewed changes
Copy link
Collaborator

@mxyng mxyng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two minor comments

@kimskimchi kimskimchi merged commit 93392aa into main Mar 4, 2022
@kimskimchi kimskimchi deleted the cli-loggedout branch March 4, 2022 01:49
@infrahq-ci infrahq-ci mentioned this pull request Mar 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmorganca jmorganca jmorganca left review comments

@mxyng mxyng mxyng approved these changes

@BruceMacD BruceMacD BruceMacD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI: All cmds except login/logout should result in a Please login error.
4 participants
@kimskimchi @jmorganca @mxyng @BruceMacD