Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nil error log when destination refreshed #1185

Merged
merged 2 commits into from
Mar 15, 2022
Merged

fix: nil error log when destination refreshed #1185

merged 2 commits into from
Mar 15, 2022

Conversation

BruceMacD
Copy link
Collaborator

@BruceMacD BruceMacD commented Mar 14, 2022

Summary

This logged a nil error on destination refresh.

{"level":"error","ts":1647282784.513224,"caller":"engine/engine.go:483","msg":"initializing destination: %!w(*errors.errorString=&{error updating existing destination: %!w(<nil>)})"}

Checklist

  • Wrote appropriate unit tests
  • Considered security implications of the change
  • Updated associated docs where necessary
  • Updated associated configuration where necessary
  • Change is backwards compatible if it needs to be (user can upgrade without manual steps?)
  • Nothing sensitive logged
  • Commit message conforms to [Conventional Commit][1]

internal/engine/engine.go Outdated Show resolved Hide resolved
Co-authored-by: Michael Yang <michael.yang@infrahq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants