Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use protocol buffers for database & api resources #20

Closed
jmorganca opened this issue Jun 11, 2021 · 1 comment
Closed

Use protocol buffers for database & api resources #20

jmorganca opened this issue Jun 11, 2021 · 1 comment
Labels
kind/feature A request or change that improves functional suitability.

Comments

@jmorganca
Copy link
Contributor

Currently API objects, database models are based off of the Go struct tags. This is great for short term and rapid changes to the API. Long term we'll need backwards compatibility and easy api generation for clients (e.g. the CLI, engine). Protocol buffers are a great way to do this.

To keep using gorm tags we can inject tags via https://github.com/favadi/protoc-go-inject-tag
@jmorganca jmorganca added the kind/feature A request or change that improves functional suitability. label Jun 11, 2021
@jmorganca
Copy link
Contributor Author

jmorganca commented Jul 5, 2021 •
edited

This was introduced on main. Not using protobufs for the database layer as this would be overkill for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature A request or change that improves functional suitability.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jmorganca