Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new comment instead of updating existing comment. #6

Open
ahublersos opened this issue May 13, 2024 · 2 comments
Open

Add new comment instead of updating existing comment. #6

ahublersos opened this issue May 13, 2024 · 2 comments

Comments

@ahublersos
Copy link

I'm testing out the self-hosted Infro, really like it so far!

I've noticed that if Infro has already posted a comment to a PR and another commit is pushed that changes the Diff Infro shows, Infro updates the existing comment. It would be nice if existing comments were left in place, minimized, and a new comment was added after the new commit.

As an example, Atlantis does this whenever it updates a pull request. It's very helpful to be able to see how commits in the PR change the diff, and having the latest changes right next to the latest commits in a PR is very convenient.

@rouke-broersma
Copy link

rouke-broersma commented May 15, 2024

This need to be at least optional. I have no need for intermediate commit results, I only need to be able to review the change as it is actually going to be merged. A better solution would be to implement github checks for the self-hosted option, because checks are linked to a specific commit, so you can find the check result for that specific result.

Infro could also place a commit-comment instead of a PR comment. You can then find the historical result on the specific commit as well but your PR would not be polluted.

@colethienes
Copy link
Contributor

Would it suffice to make this configurable? As in, an upsert mode if you want to replace the existing diff, and another mode for creating a new diff PR comment for each commit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants