You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm testing out the self-hosted Infro, really like it so far!
I've noticed that if Infro has already posted a comment to a PR and another commit is pushed that changes the Diff Infro shows, Infro updates the existing comment. It would be nice if existing comments were left in place, minimized, and a new comment was added after the new commit.
As an example, Atlantis does this whenever it updates a pull request. It's very helpful to be able to see how commits in the PR change the diff, and having the latest changes right next to the latest commits in a PR is very convenient.
The text was updated successfully, but these errors were encountered:
This need to be at least optional. I have no need for intermediate commit results, I only need to be able to review the change as it is actually going to be merged. A better solution would be to implement github checks for the self-hosted option, because checks are linked to a specific commit, so you can find the check result for that specific result.
Infro could also place a commit-comment instead of a PR comment. You can then find the historical result on the specific commit as well but your PR would not be polluted.
Would it suffice to make this configurable? As in, an upsert mode if you want to replace the existing diff, and another mode for creating a new diff PR comment for each commit?
I'm testing out the self-hosted Infro, really like it so far!
I've noticed that if Infro has already posted a comment to a PR and another commit is pushed that changes the Diff Infro shows, Infro updates the existing comment. It would be nice if existing comments were left in place, minimized, and a new comment was added after the new commit.
As an example, Atlantis does this whenever it updates a pull request. It's very helpful to be able to see how commits in the PR change the diff, and having the latest changes right next to the latest commits in a PR is very convenient.
The text was updated successfully, but these errors were encountered: