Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infro does not detect changes on ArgoCD Apps that use the "ssh" formated URLs github repos #7

Open
ahublersos opened this issue May 13, 2024 · 0 comments

Comments

@ahublersos
Copy link

I've set up infro with ahublersos as the configured "owner" and I've found that it detects changes in ArgoCD apps whose source includes the "HTTPS" formatted repo url (https://github.com/ahublersos/argocd-example-apps.git) but it will not detect apps that use the "SSH" formatted repo url (git@github.com:ahublersos/argocd-example-apps.git).

I confirmed this by changing the source of an app Infro was not detecting from SSH to HTTPS. After this change Infro began working for the app and detecting incoming changes in PRs.

It looks like when ExecuteDryRuns() is called the RepoURL is set to vcsClient.RepoURL which always returns a https:// url. It would be great for Infro to be able to include the "SSH" formatted repo urls as well since there's no guarantee that a given github repo will be configured one way or the other within ArgoCD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant