Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access token refreshing #9

Closed
skeemer opened this issue Sep 21, 2014 · 6 comments
Closed

Access token refreshing #9

skeemer opened this issue Sep 21, 2014 · 6 comments

Comments

@skeemer
Copy link
Contributor

skeemer commented Sep 21, 2014

It seems in my reading of the code that I will have to add a try/catch and a loop around every call because of token expiration. Is there a reason the request() function doesn't refresh the access token if it's expired?

@mfairch
Copy link
Contributor

mfairch commented Sep 21, 2014

We are discussing implementing this. The only downfall is that the developer needs the new refresh token to store for future use. We are discussing possible solutions that will accommodate both.

@skeemer
Copy link
Contributor Author

skeemer commented Sep 21, 2014

Oh, so you get back both a new refresh token and access token?

@mfairch
Copy link
Contributor

mfairch commented Sep 21, 2014

When you request a new access token, the refresh token you had expires and you get a new refresh token.

@skeemer
Copy link
Contributor Author

skeemer commented Sep 21, 2014

What about auto-refreshing if a callback function is setup for handling saving the new Token?

@mfairch mfairch closed this as completed Sep 21, 2014
@mfairch mfairch reopened this Sep 21, 2014
@mfairch
Copy link
Contributor

mfairch commented Sep 21, 2014

Wrong button. We have a few solutions we are looking at but we'll keep that in mind.

@skeemer
Copy link
Contributor Author

skeemer commented Sep 21, 2014

Okay. Will watch the commits for resolution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants