You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Originally, the FieldCustomMixin was created to be used in conjunction with 'specialized' fields (input-iban, input-amount, input-date etc.) having defaults for help-texts, labels etc.
In the Lion versions of the specialized inputs mentioned above we have no default help-texts/labels applied. Therefore, the FieldCustomMixin has more right of existence on more opinionated, extending layers (not in Lion repo).
Currently, its functionality contains only the disabling of help-texts. For maximum flexibility, on extending layers it should contain:
disable predefined help-texts and labels
make sure that a label/help-text defined by an app developer 'wins' from a predefined one (this involves some logic since localisation resources are often lazily loaded)
If we would decide however to keep this mixin, we should rename it to something like 'SpecializedFieldMixin', to avoid confusion with custom field wrappers like described here: https://github.com/ing-bank/lion/tree/master/packages/field
The text was updated successfully, but these errors were encountered:
bashmish
changed the title
[proposal] consider removing FieldCustomMixin
[form] [proposal] consider removing FieldCustomMixin
May 7, 2019
We are closing this issue because we're changing the way we handle feature requests. Your issue will get the "votes needed" label, and people can add 👍 reactions to vote and show interest. It will be reopened when this feature gets picked up.
This we way we clearly focus on bugs in our open issues. At the same time we can see what community interest there is for new features.
Originally, the
FieldCustomMixin
was created to be used in conjunction with 'specialized' fields (input-iban, input-amount, input-date etc.) having defaults for help-texts, labels etc.In the Lion versions of the specialized inputs mentioned above we have no default help-texts/labels applied. Therefore, the FieldCustomMixin has more right of existence on more opinionated, extending layers (not in Lion repo).
Currently, its functionality contains only the disabling of help-texts. For maximum flexibility, on extending layers it should contain:
If we would decide however to keep this mixin, we should rename it to something like 'SpecializedFieldMixin', to avoid confusion with custom field wrappers like described here: https://github.com/ing-bank/lion/tree/master/packages/field
The text was updated successfully, but these errors were encountered: