Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[form] [proposal] consider removing FieldCustomMixin #28

Closed
tlouisse opened this issue May 7, 2019 · 2 comments
Closed

[form] [proposal] consider removing FieldCustomMixin #28

tlouisse opened this issue May 7, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@tlouisse
Copy link
Member

tlouisse commented May 7, 2019

Originally, the FieldCustomMixin was created to be used in conjunction with 'specialized' fields (input-iban, input-amount, input-date etc.) having defaults for help-texts, labels etc.

In the Lion versions of the specialized inputs mentioned above we have no default help-texts/labels applied. Therefore, the FieldCustomMixin has more right of existence on more opinionated, extending layers (not in Lion repo).

Currently, its functionality contains only the disabling of help-texts. For maximum flexibility, on extending layers it should contain:

  • disable predefined help-texts and labels
  • make sure that a label/help-text defined by an app developer 'wins' from a predefined one (this involves some logic since localisation resources are often lazily loaded)

If we would decide however to keep this mixin, we should rename it to something like 'SpecializedFieldMixin', to avoid confusion with custom field wrappers like described here: https://github.com/ing-bank/lion/tree/master/packages/field

@bashmish bashmish changed the title [proposal] consider removing FieldCustomMixin [form] [proposal] consider removing FieldCustomMixin May 7, 2019
@tlouisse tlouisse mentioned this issue May 28, 2019
@erikkroes erikkroes added enhancement New feature or request votes needed Enhancement available for voting labels Nov 13, 2019
@erikkroes
Copy link
Collaborator

Hi,

We are closing this issue because we're changing the way we handle feature requests. Your issue will get the "votes needed" label, and people can add 👍 reactions to vote and show interest. It will be reopened when this feature gets picked up.

This we way we clearly focus on bugs in our open issues. At the same time we can see what community interest there is for new features.

Thanks!

@daKmoR
Copy link
Collaborator

daKmoR commented Sep 28, 2020

FieldCustomMixin get removed 👍

@daKmoR daKmoR removed the votes needed Enhancement available for voting label Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants