Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the setup.py file to include requirement sets #65

Closed
anilkumarpanda opened this issue Feb 3, 2021 · 2 comments
Closed

Update the setup.py file to include requirement sets #65

anilkumarpanda opened this issue Feb 3, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@anilkumarpanda
Copy link
Contributor

Problem Description
As of now, there is no requirement.txt , inorder to make it easier for the developers to contribute to we can define sets in the setup.py file.

Desired Outcome
The setup.py file is updated to include sets.
We should also update CONTRIBUTING.md and the different github action pipelines.

Solution Outline
Sets would be: documentation, tests, development, core, and all. E.g setup
Define these sets via install_requires and extras_require.
You can then install what you need via pip install probatus[name-of-set].

Refer this issue for the detailed discussion.

@anilkumarpanda anilkumarpanda added the enhancement New feature or request label Feb 3, 2021
@Matgrb
Copy link
Collaborator

Matgrb commented Feb 25, 2021

Great issue, feel free to pick it up.

We should also add the extra requirements for setting up the mkdocs documention:

mkdocs-material>=6.1.0
mkdocs-git-revision-date-localized-plugin>=0.7.2
mkdocs-git-authors-plugin>=0.3.2
mkdocs-table-reader-plugin>=0.4.1
mkdocs-enumerate-headings-plugin>=0.4.3
mkdocs-awesome-pages-plugin>=2.4.0
mkdocs-minify-plugin>=0.3.0
mknotebooks>=0.6.2
mkdocs-print-site-plugin>=0.8.2
mkdocs-markdownextradata-plugin>=0.1.9

@timvink timvink self-assigned this Feb 26, 2021
@timvink
Copy link
Collaborator

timvink commented Feb 26, 2021

Picking this up now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants