Suggestion: Consider alternate method name for Key generation

[tep]

Per your RFC in #reviews -- regarding:

smokering/smokering.go

Line 29 in c9e16dd

func (kr *Smokering) New(id, note string, block cipher.Block, blocksize int, f func() ([]byte, error)) (*Key, error) {

A common pattern I like to use, when I have a package level constructor named New returning a factory object that itself creates some other object, is to use the child object's name as the name of the factory method that creates it.

In this case, instead of:

    func (kr *Smokering) New(...

... you'd have:

    func (kr *Smokering) Key(...

I've found that it can make things a lot clearer 6 months down the road (given that the word New is often grossly overloaded).

[IngCr3at1on]

This is implemented in cfba85f thanks @tep for the suggestion.