Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] per URL override settings #1

Open
Lockszmith-GH opened this issue Jan 31, 2018 · 9 comments
Open

[Feature Request] per URL override settings #1

Lockszmith-GH opened this issue Jan 31, 2018 · 9 comments

Comments

@Lockszmith-GH
Copy link

Awesome Zoom add-on.
Probably the best thought off zoom solution I've encountered.
So - first - Thank You!

My request: have the ability to toggle the current page in/out of an exclusion list for the auto-zoom.

The first URL I'll add to this list would be about:addons.

Thanks in advance.

@ingolemo
Copy link
Owner

Why specifically the about:addons page? It should look fine for any zoom width other than 800 (which is also horribly small for just about every other webpage). This is a feature that would be nice to have and I might add it when I find time, but if there's something broken in about:addons then I'd put a rush on fixing it.

@Lockszmith-GH
Copy link
Author

The actual Add On manager looks ok, but some options windows enter a rendering loop for some reason.

This happened to me with "Lyrics Here by Rob W" and "Temporary Containers".
Besides, such a blacklist would allow to custom zoom for certain sites, and yet continue using dynamic zoom everywhere else.

@ingolemo
Copy link
Owner

ingolemo commented Feb 1, 2018

I can't seem to reproduce the issue on my end with either of those addons. Could you provide more detailed instructions, or a screenshot or something?

@darkj2k
Copy link

darkj2k commented Jul 30, 2018

A blacklist function will be great. Also, is it normal that webextension element was effected by Dynamic Zoom? For example, the popup window size of Swift Selection Search is changed by Dynamic Zoom level.

@ingolemo
Copy link
Owner

That SSS element is not really a popup window in a technical sense. It's part of the webpage and can't easily be zoomed separately from it. I don't think it needs to be anyway, as the zoomed version looks fine to me.

My main issue with the blacklist is that I don't currently understand the use-case for it. Right now, dynamic zoom is an intentionally simple addon. Introducing a blacklist wouldn't be hard per-say, but it would make everything more complicated. I'd have to add a preferences window to let you manage the blacklist and I'd have to come up with rules about how you specify sites (is www.example.com caught by a blacklist for example.com, for example). I'd have to save those preferences and update the different parts of the UI to keep them in sync. Like I said; this isn't hard, but it would increase the amount of code in the project ten-fold and I'm not sure that's really worth it. I'd rather just fix issues so that all webpages zoom correctly to begin with and no-one needs any manual control.

All that said, I'm not opposed to adding a blacklist. But I would want to know what problems you guys are actually having and how those problems would be best solved specifically by adding a blacklist. Convince me.

@millionart
Copy link

When the zoom ratio exceeds 100%, the simple image address cannot be displayed completely (https://***.png etc.)

@ingolemo
Copy link
Owner

ingolemo commented Feb 1, 2019

I'm not really sure what you're referring to. Could you provide more details?

@millionart
Copy link

My zoom ratio is 200%, everything is perfect, but all open image links are up to 200% and therefore cannot be fully displayed.
I want to increase the address exclusion feature that supports regular expressions.

@crssi
Copy link

crssi commented Aug 11, 2019

@Lockszmith

The first URL I'll add to this list would be about:addons.

about:addons is a special mozilla page (there are other mozilla pages like that too), where web extensions does not work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants