Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BN254 MSM slowdown when using multiple curves #5

Closed
jeremyfelder opened this issue Sep 14, 2023 · 2 comments
Closed

BN254 MSM slowdown when using multiple curves #5

jeremyfelder opened this issue Sep 14, 2023 · 2 comments
Assignees
@DmytroTym @jeremyfelder
Labels
type:bug Something isn't working

Comments

@jeremyfelder
Copy link
Collaborator

When importing multiple curves from iciclegnark into another project and running a circuit that uses only BN254, the timing of MSM slows down by 10-20x.
@jeremyfelder jeremyfelder self-assigned this Sep 14, 2023
@jeremyfelder
Copy link
Collaborator Author

The slowdown is occurring due to the kernels find_cutoff_kernel and find_max_size not finding any "large" buckets thus causing the skewed scalar optimization to not run.

When find_cutoff_kernel is called, the arguments are not correct inside the kernel (they are all 0); the values of these arguments are correct on the host before the kernel call.

@jeremyfelder jeremyfelder added the type:bug Something isn't working label Oct 10, 2023
@DmytroTym DmytroTym mentioned this issue Oct 12, 2023
Merged
@jeremyfelder
Copy link
Collaborator Author

The issue stemmed from a collision of the same functions from two separate binaries. The fix was made in ingonyama-zk/icicle#245

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DmytroTym DmytroTym

@jeremyfelder jeremyfelder

Labels
type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DmytroTym @jeremyfelder