Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Inline::CPP needs to bundle PRD in inc #12

Closed
ingydotnet opened this Issue Dec 9, 2014 · 4 comments

Comments

Projects
None yet
2 participants
Owner

ingydotnet commented Dec 9, 2014

for now, since it only has a grammar for PRD.

Also we need to work out how I:CPP overrides grammars.

Probably needs to have separate grammar modules like Inline::C, and not just
override get_parser directly.

Collaborator

daoswald commented Dec 10, 2014

I'm not sure on this (even though you are most likely right). PRD is only necessary when Inline::CPP is in use. That only happens when we're in development mode. Developers would already have installed Inline::CPP, and in so doing, would have pulled in the PRD dependency automatically.

Owner

ingydotnet commented Dec 12, 2014

@daoswald, I think PRD is needed to build the installable .so during user
install. No?

Owner

ingydotnet commented Dec 12, 2014

@daoswald, never heard back from you. Closing this now. I think PRD needs to be
bundled and it's currently working that way.

If you disagree, please repoen.

@ingydotnet ingydotnet closed this Dec 12, 2014

Collaborator

daoswald commented Dec 18, 2014

You were right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment