Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove geemap dependency #145

Open
iona5 opened this issue Jun 21, 2024 · 2 comments · Fixed by #152
Open

remove geemap dependency #145

iona5 opened this issue Jun 21, 2024 · 2 comments · Fixed by #152

Comments

@iona5
Copy link
Collaborator

iona5 commented Jun 21, 2024

geemap pulls in an awful lot of dependencies. currently we use it only in the sentinel-2 download and preformat files:

  • src\thaw_slump_segmentation\scripts\download_s2_4band_planet_format.py
  • src\thaw_slump_segmentation\scripts\prepare_s2_4band_planet_format.py

which are as far as i can see superseded as this is done in thaw-slump-segmentation-pipeline and in branch sentinel2_native.

we should remove the geemap dependency once sentinel2 is stable to make packaging easier. if necessary functionality can be reproduced, as we use only download capabilities (uses geedim anyway) and data conversion from and to GeoDataFrame.

@initze
Copy link
Owner

initze commented Jul 15, 2024

    df = ee.data.computeFeatures({
        'expression': ftrCollection,
        'fileFormat': 'GEOPANDAS_GEODATAFRAME'
    })

@initze initze linked a pull request Jul 15, 2024 that will close this issue
@initze initze reopened this Jul 15, 2024
@initze
Copy link
Owner

initze commented Jul 15, 2024

partially completed with #152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants