Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

injective-protobuf isn't generating the types for all of the proto files #149

Closed
ewoolsey opened this issue Jun 16, 2023 · 3 comments · Fixed by #150
Closed

injective-protobuf isn't generating the types for all of the proto files #149

ewoolsey opened this issue Jun 16, 2023 · 3 comments · Fixed by #150

Comments

@ewoolsey
Copy link
Contributor

ewoolsey commented Jun 16, 2023

Perhaps there is a reason for this that I'm not aware of, but it seems injective-protobuf is not building all of the types defined in the .proto files. An example being EthAccount. This can be fixed by simply adding the paths to the missing proto files into the inputs in build.rs. I would be happy to submit a PR for this if it will be accepted.

@ewoolsey ewoolsey changed the title injective-protobuf isn't generating the types for all of the photo files injective-protobuf isn't generating the types for all of the proto files Jun 16, 2023
@ewoolsey
Copy link
Contributor Author

Additionally, it would be very helpful to have an official release on crates.io, even if it's just a beta release.

@maurolacy
Copy link
Collaborator

maurolacy commented Jun 19, 2023

Please check if there are more types that need to be added.

It would also be a good opportunity to improve the release process of this package, and to define the authoritative sources of the third party packages, as they are not copied in injective-core anymore.

@albertchon, can you define the references for them? What about publishing this package to crates-io?

@maurolacy
Copy link
Collaborator

Some progress in #164.

Will publish to crates.io soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants