Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistency in model.py predict() with timesteps for subject vs object #64

Open
JuliaGast opened this issue May 23, 2022 · 1 comment

Comments

@JuliaGast
Copy link

Hello,

I found an inconsistency:
predict(), l. 223:
_, sub, prob_sub = global_model.predict(self.latest_time, self.graph_dict, subject=True)

vs

predict(), l. 261:
_, ob, prob_ob = global_model.predict(t, self.graph_dict, subject=False)

why do you pass the self.latest_time for the subjects, and t for the objects, whereas clearly they are not the same (see line 222)?

@woojeongjin
Copy link
Contributor

woojeongjin commented Aug 17, 2022

Each subject and object have different latest times since each subject's last interaction (with possibly another object) and each object's last interaction (with possibly another subject) are different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants